-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Volume control, allow for a fixed volume option #447
Conversation
Thanks for this, will give it a test. W.R.T the breaking aspect, we might have to hold off merging this for a bit. We might be best off considering this for the v1 release, along with #134. Also, at some point we need to start thinking about fleshing out librespotd, and stabilising librespot as the core library. That way changes such as these can be added to the former without breaking the latter. |
@sashahilton00 just to clarify the "breaking" change here would be the flag passed into the binary, and the |
This can be reviewed and merged to dev now that |
@ashthespy since the docs are broken and shouldn't really be, I think we can just merge this into dev along with #504 (assuming this is actually a fix) and release it as |
Sounds like a plan, I'll fix the conflicts later today. |
Rebased on dev, and fixed the conflicts. I was a bit trigger happy with the merge, but it should be all good now. Wiki has also been updated. |
Adapts to the changes from librespot-org/librespot#447
Adapts to the changes from librespot-org/librespot#447
Adapts to the changes from librespot-org/librespot#447
This is a (long) overdue follow up to #286 (comment).
I have refactored the old
--linear-volume
flag to a more generic--volume-ctrl
option that takes the options of[linear, log, fixed]
. It defaults as previously tolog
.What
fixed
does is disable the client side volume control, by settingkVolumeSteps
to 0, so no volume events are passed to the client.As usual, this will need a update of the wiki, and should be considered a "breaking change" when considering the versioning.
Fixes #48, Closes #286