Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subscription uri #291

Merged

Conversation

forslund
Copy link
Contributor

This fixes an issue loading new tracks probably caused by an update on spotify's side. The fix was suggested by @worleydl, all glory to them for figuring it out.

Resolves #288

This fixes an issue loading new tracks probably caused by an update on spotify's side. The fix was suggested by @worleydl, all glory to them for figuring it out.
@sashahilton00
Copy link
Member

@kingosticks once you've tested and confirmed working, we'll merge this.

@kingosticks
Copy link
Contributor

Yep. Works perfectly again for me too. Thanks @forslund and @worleydl.

@IsaacWoods
Copy link

IsaacWoods commented Feb 22, 2019

Similar URIs appear elsewhere in the codebase (here, here and here). Has anyone confirmed whether these still work?

@aksel
Copy link

aksel commented Feb 22, 2019

Similarly, but not metadata, here.

@sashahilton00
Copy link
Member

sashahilton00 commented Feb 22, 2019

Hmmm, we should probably update the url at #217 in spirc.rs, as mentioned above, as that's essentially the same problematic endpoint. EDIT: Just saw that the file @aksel is the target of the PR.

From what I can surmise though, metadata, users, etc. are all seperate services in Spotify's backend, and thus the necessary update to the URI of the users endpoint doesn't necessarily coincide with a change in the metadata endpoint. I suggest we leave the metadata uri's the same until a similar problem is encountered.

@forslund
Copy link
Contributor Author

The L217 in spircs.rs is what this PR addresses, or am I missunderstanding something?

@sashahilton00
Copy link
Member

sashahilton00 commented Feb 22, 2019

No you missed nothing, I did. Going to merge this.

@aksel
Copy link

aksel commented Feb 22, 2019

You are right, and I am blind :~)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting playback fails if uri or context_uri is provided
5 participants