Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sinc closed event when connection is lost. #600

Closed
aliher1911 opened this issue Feb 11, 2021 · 3 comments
Closed

No sinc closed event when connection is lost. #600

aliher1911 opened this issue Feb 11, 2021 · 3 comments

Comments

@aliher1911
Copy link

I sometimes experience connection issues where librespot loses connection:
ERROR librespot_core::session] Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" }
and playback is stopped.

In that case sink closed event is not generated.
I'm using those events to power off speakers when there's no playback and turn them back on when sink start event arrives. So if connection drops, monitoring program keeps everything powered. It would be helpful to either send sink stop or some other event indicating that playback was stopped.

@sashahilton00
Copy link
Member

Related to #134

@roderickvd
Copy link
Member

Will be fixed when we get the new API in, which is factoring in reconnection support from the ground up.

@roderickvd
Copy link
Member

Duplicate of #276.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants