-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow to connect to Librespot #1394
Comments
Update: It appears that this appears to be more of a problem when there are multiple librespot instances on the same network and you switch from one to the other or you attempt to connect to a new instance after disconnecting from another. I will update this post as I learn more. |
You might also want to run it with the |
I'm running with the --release flag but I'm still having issues. It seems like when changing from connecting to one librespot instance to another is problematic. It seems to hang for a while and occasionally you'll have both librespot instances playing simultaneously but out of sync when moving from one connection to another. Can anyone else reproduce this? |
It seems like this may have something to do with the fact that even when disconnecting the spotify app from the device, the session with the spotify server is never actually closed. I'm seeing that even when switching connection from one librespot instance to another, the previous instance continues to send data to the server when pausing/playing to the newly connected librespot instance. I can also get it to quickly switch from one connection to another by keyboard interrupting the first instance aright after starting a connection attempt to a second instance. |
I've seen other reports of librespot disconnects not being picked up properly in the current code base. Though it's experimental, could you take #1356 for a spin? If the new |
A friend of mine tried out the dealer branch and seemed to have run into this problem using discovery/zeroconf while first connecting. Afterwards (without caching) it was instant tho. So might not have to do something with the spirc/dealer and is maybe more a discovery problem? I didn't look into it myself tho, so it might also be an entirely different topic. |
Strike all that, I was on the wrong branch. #1356 solves this problem entirely for me! |
Great work on this! Changing connections is pretty seemless now. The only problem though is that when switching from connecting to one librespot instance to another, something goes wrong and my phone fails to establish the new connection and it will drop all previous connection. The easy workaround is to try again and that usually works. @photovoltex Is that something you're aware of? EDIT: Another thing I noticed was that it would sometimes go back to a previous song when switching connections from one librespot instance to another. I'm having trouble reproducing it now but it did happen once. |
So far i only tested with a single instance and never tried transferring from one librespot instance to another. A bummer that it doesn't work out of the box, but probably has something to do with the initial transfer handling.
yeah, sometimes it does resolve some positions incorrectly. didn't figure out what it triggers yet tho but yeah the branch still has some problems here and there, the general usage should be given but some edge cases i personally don't used that often are not fully covered/tested yet. Anyhow, if you have any other issues, ideas or trouble with the branch, we should probably continuing it on #1356 itself. Any feedback, testing or issue reporting on the state is welcome :D |
Description
When connecting to librespot, the application hangs for up to 33 seconds before successfully establishing a connection and appearing within the Spotify Connect app
Version
The latest build of the dev branch (82076e8). Built with flags
--features alsa-backend --features with-dns-sd
How to reproduce
Steps to reproduce the behavior in librespot e.g.
cargo run -- -n test1 --zeroconf-port 10000
cargo run -- --n test2 --zeroconf-port 10001
Log
Host (what you are running
librespot
on):Additional context
The text was updated successfully, but these errors were encountered: