Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mini player overlaps navigation bar #5694

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: mini player overlaps navigation bar #5694

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84440b3
-Fix mini player overlapping navigation bar (#5692)
KhubaibKhan4 Mar 3, 2024
1e3c8f4
--Fix mini player overlapping navigation bar (#5692)
KhubaibKhan4 Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/src/main/java/com/github/libretube/ui/activities/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import androidx.activity.addCallback
import androidx.activity.viewModels
import androidx.appcompat.widget.SearchView
import androidx.constraintlayout.widget.ConstraintSet
import androidx.core.content.pm.ShortcutManagerCompat
import androidx.core.os.bundleOf
import androidx.core.view.allViews
Expand Down Expand Up @@ -168,7 +169,7 @@

R.id.searchResultFragment -> {
navController.popBackStack(R.id.searchFragment, true) ||
navController.popBackStack()
navController.popBackStack()

Check failure on line 172 in app/src/main/java/com/github/libretube/ui/activities/MainActivity.kt

View workflow job for this annotation

GitHub Actions / Check Code Quality 

[ktlint] reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)

Raw Output:
app/src/main/java/com/github/libretube/ui/activities/MainActivity.kt:172:1: error: Unexpected indentation (28) (should be 24) (standard:indent)
}

else -> {
Expand Down Expand Up @@ -455,7 +456,8 @@
linLayout.isVisible = true
playerMotionLayout.setTransitionDuration(250)
playerMotionLayout.transitionToEnd()
playerMotionLayout.getConstraintSet(R.id.start).constrainHeight(R.id.player, 0)
playerMotionLayout.getConstraintSet(R.id.start)
.constrainHeight(R.id.player, ConstraintSet.WRAP_CONTENT)
playerMotionLayout.enableTransition(R.id.yt_transition, true)
}
(fragment as? AudioPlayerFragment)?.binding?.apply {
Expand Down
Loading