You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is more of a discussion than an a bug report.
I noticed that LibreTube (master branch) overrides the default predictive back animations that you get for free when using the navigation component. Because of this it is also not possible to override animations the usual way by setting an enterTransition or an exitTransition. Is this intended?
I created a branch yesterday with the changes I'm proposing: https://github.com/Pittvandewitt/LibreTube/tree/feat/default-animations
It is not fully implemented yet, and it takes a lot more work to do so. The enter animation should be postponed until all data is loaded in the recyclerview, among other things.
What do you think?
Expected behavior
Animations should feel "predictive" by previewing where the user would navigate to
Actual behavior
The default "exit activity" navigation is used, even in fragments
LibreTube version
0.26.0 (58)
Android version
Any
Other details
No response
Acknowledgements
I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
I have written a short but informative title.
I will fill out all of the requested information in this form.
The text was updated successfully, but these errors were encountered:
I noticed that LibreTube (master branch) overrides the default predictive back animations that you get for free when using the navigation component.
When I last tested it, there haven't actually been any predictive back animations between fragments, only between activities. Thus the current workaround.
It's possible that they added support for it recently though, can't tell.
Steps to reproduce
This is more of a discussion than an a bug report.
I noticed that LibreTube (master branch) overrides the default predictive back animations that you get for free when using the navigation component. Because of this it is also not possible to override animations the usual way by setting an enterTransition or an exitTransition. Is this intended?
I created a branch yesterday with the changes I'm proposing: https://github.com/Pittvandewitt/LibreTube/tree/feat/default-animations
It is not fully implemented yet, and it takes a lot more work to do so. The enter animation should be postponed until all data is loaded in the recyclerview, among other things.
What do you think?
Expected behavior
Animations should feel "predictive" by previewing where the user would navigate to
Actual behavior
The default "exit activity" navigation is used, even in fragments
LibreTube version
0.26.0 (58)
Android version
Any
Other details
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: