Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-generated captions not working if HLS enabled #5511

Open
3 tasks done
clicky6 opened this issue Jan 18, 2024 · 11 comments
Open
3 tasks done

auto-generated captions not working if HLS enabled #5511

clicky6 opened this issue Jan 18, 2024 · 11 comments
Labels
bug Something isn't working

Comments

@clicky6
Copy link

clicky6 commented Jan 18, 2024

Steps to reproduce

  1. Disable piped proxy (Enabled)
  2. Fallback to piped proxy (Disabled)
  3. Use HLS (Enabled)
  4. Play any video with English (auto-generated) captions, the captions aren't visible.

Expected behavior

The English (auto-generated) captions should be visible and should show normally as when we play using piped proxy.

Actual behavior

The English (auto-generated) captions weren't visible.

LibreTube version

0.21.1

Android version

Android 13

Other details

https://send.internxt.com/download/7fa7d69b-222f-42df-a37a-2e5e275cb3ce?code=d90a34709d742dc1618504f7dfaa07f3c883ab40ee8519d040a572466e727f07

In the demonstration video above

When the YouTube video is played for the first time in Libretube with the settings
Disable piped proxy is (Disabled)
Use HLS is (Disabled)
the English (auto-generated) captions are showing.

And When I play it for the 2nd time with
Disable piped proxy (Enabled)
Use HLS (Enabled)
The English (auto-generated) captions are not showing.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@clicky6 clicky6 added the bug Something isn't working label Jan 18, 2024
@marnix
Copy link

marnix commented Jan 23, 2024

This seems purely related to HLS: for me, keeping the piped proxy enabled, enabling HLS stops auto-generated subtitles from showing. (All other subtitles still work.)

@clicky6
Copy link
Author

clicky6 commented Jan 24, 2024

This seems purely related to HLS: for me, keeping the piped proxy enabled, enabling HLS stops auto-generated subtitles from showing. (All other subtitles still work.)

Absolutely

@Bnyro Bnyro changed the title English (auto-generated) captions not showing when Disable piped proxy is (Enabled) & Use HLS is (Enabled) auto-generated captions not showing if HLS enabled Feb 4, 2024
@Taratect
Copy link

Taratect commented Apr 22, 2024

I have hls disabled. Still no auto captions for me. Though I have disabled piped proxy.

Edit: I wanted to see how the app reacts when I enable hls. The video loads however it buffers somewhat

@clicky6
Copy link
Author

clicky6 commented Apr 23, 2024

I have hls disabled. Still no auto captions for me. Though I have disabled piped proxy

For me videos don't play without HLS in disabled piped proxy

@Taratect
Copy link

I have hls disabled. Still no auto captions for me. Though I have disabled piped proxy

For me videos don't play without HLS in disabled piped proxy

Lol for me, Videos don't play when I use DASH (hls disabled) using the piped proxy. And I have to use his if I want to view vids via piped proxy. Looks like we're having different issues for some reason.

Piped had this bug before. Now it has been fixed. The auto generated cc loads

@strangersdangers
Copy link

What I've noticed in the Piped API is that when there's two subtitles with the same code (for example, two en subtitles, one is auto generated and one isn't), the one with the "false" autoGenerated will get picked over the auto generated one

@RaptaG
Copy link

RaptaG commented Jun 23, 2024

I can reproduce on my end, what is the status of this issue?

@strangersdangers
Copy link

No idea.

But just to add to my previous message, even when there's only one caption on a video, if its "autoGenerated" is true, it's not going to get displayed.

Why is this app picking "false" autoGenerated captions to be displayed over the "true" ones?

@ghost ghost mentioned this issue Jul 13, 2024
3 tasks
@TechD123
Copy link

Can confirm what @Taratect reports: I can only use Piped proxies with HLS enabled, otherwise an error toast appears. When deactivating Piped proxies, I can use both HLS and DASH. The issue tracking that appears to be #5855, so I'd recommend to take further discussions of that issue there.

I wasn't even able to display English auto generated subs when I disabled Piped proxies and set it to DASH (HLS disabled), as the heading of this ticket suggests. Happy to provide logs if needed.

@clarfonthey
Copy link

I don't seem to get automatic subtitles regardless of proxy/HLS settings. Works fine with non-automatic subtitles, though.

My guess would be that it's because the auto-generated captions have a different format (going one word at a time) but I wouldn't know without going through the code.

@Bnyro Bnyro changed the title auto-generated captions not showing if HLS enabled auto-generated captions not working if HLS enabled Sep 7, 2024
@Bnyro Bnyro mentioned this issue Sep 7, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants
@marnix @clarfonthey @TechD123 @RaptaG @Taratect @clicky6 @strangersdangers and others