Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Enter/exit fullscreen gesture is enabled the Fullscreen orientation in the Player settings (Landscape, video aspect ratio) does not work properly #5158

Closed
3 tasks done
Eliya-Manoj opened this issue Nov 15, 2023 · 4 comments
Labels
bug Something isn't working can't reproduce

Comments

@Eliya-Manoj
Copy link

Eliya-Manoj commented Nov 15, 2023

Steps to reproduce

  1. Open LibreTube
  2. Enable Enter/exit fullscreen gestures in Player settings
  3. Fullscreen orientaion ( select video aspect ratio or Landscape ) in Player settings
  4. Play Video and swipe up to fullscreen
2023-11-15_23-22-19.mp4

Expected behavior

Fullscreen based on aspect ratio. If Landscape, Video plays in landscape.

Actual behavior

Enter fullscreen in landscape and then suddenly change to portrait.

LibreTube version

0.20.0 - 0.23.2

Android version

Android 12

Other details

#5160 based on this issue.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Eliya-Manoj Eliya-Manoj added the bug Something isn't working label Nov 15, 2023
@Eliya-Manoj Eliya-Manoj changed the title Enter/exit fullscreen gesture not working properly If Enter/exit fullscreen gesture is enabled the Fullscreen orientation(Landscape, video aspect ratio) does not work properly Nov 17, 2023
@Eliya-Manoj
Copy link
Author

Reproducible version 0.20.0. I can't reproduce in Latest Debug.

If i disable Enter/exit fullscreen gesture, no issues in video orientation.

@xlash123
Copy link

I also have this issue in 0.20.0. Only occurs when using the gesture. Pressing the fullscren button behaves as expected.

@Surbbd
Copy link

Surbbd commented Nov 19, 2023

This issue continues with 20.1 release, to reproduce use gestures to fullscreen the video and this happens.

@Eliya-Manoj Eliya-Manoj changed the title If Enter/exit fullscreen gesture is enabled the Fullscreen orientation(Landscape, video aspect ratio) does not work properly If Enter/exit fullscreen gesture is enabled the Fullscreen orientation in the Player settings (Landscape, video aspect ratio) does not work properly Jan 6, 2024
@Bnyro
Copy link
Member

Bnyro commented Oct 21, 2024

This should be fixed by now.

@Bnyro Bnyro closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can't reproduce
Projects
None yet
Development

No branches or pull requests

4 participants