Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-fullscreen is broken again #5061

Closed
3 tasks done
DanielProg39 opened this issue Oct 29, 2023 · 1 comment · Fixed by #5062
Closed
3 tasks done

Auto-fullscreen is broken again #5061

DanielProg39 opened this issue Oct 29, 2023 · 1 comment · Fixed by #5062
Labels
bug Something isn't working

Comments

@DanielProg39
Copy link

DanielProg39 commented Oct 29, 2023

Steps to reproduce

Make sure that screen orientation in general settings is set to portrait.
Make sure auto-fullscreen is enabled in the player settings.
Turn the phone to landscape orientation and open a video - the app crashes.
Open a video in portrait mode and then rotate the phone to landscape - the video doesn't switch to full screen.

Expected behavior

Video should switch to full screen mode.

Actual behavior

Either the app crashes or nothing happen.

I suppose that this problem is caused by changes aiming to fix #5015

2_5327842089566748067.mp4

LibreTube version

LibreTube Debug 0.19.0 commit a212e0a

Android version

Android 13

Other details

Traceback

kotlin.UninitializedPropertyAccessException: lateinit property streams has not been initialized
	at com.github.libretube.ui.fragments.PlayerFragment.setFullscreen(PlayerFragment.kt:529)
	at com.github.libretube.ui.fragments.PlayerFragment.onConfigurationChanged(PlayerFragment.kt:1615)
	at androidx.fragment.app.Fragment.performConfigurationChanged(Fragment.java:3241)
	at androidx.fragment.app.FragmentManager.dispatchConfigurationChanged(FragmentManager.java:3090)
	at androidx.fragment.app.FragmentManager.lambda$new$0$androidx-fragment-app-FragmentManager(FragmentManager.java:469)
	at androidx.fragment.app.FragmentManager$$ExternalSyntheticLambda0.accept(Unknown Source:4)
	at androidx.activity.ComponentActivity.onConfigurationChanged(ComponentActivity.java:919)
	at androidx.appcompat.app.AppCompatActivity.onConfigurationChanged(AppCompatActivity.java:229)
	at com.github.libretube.ui.activities.MainActivity.onConfigurationChanged(MainActivity.kt:486)
	at android.app.ActivityThread.performActivityConfigurationChanged(ActivityThread.java:5947)
	at android.app.ActivityThread.performConfigurationChangedForActivity(ActivityThread.java:5861)
	at android.app.ActivityThread.handleActivityConfigurationChanged(ActivityThread.java:6181)
	at android.app.servertransaction.ActivityConfigurationChangeItem.execute(ActivityConfigurationChangeItem.java:53)
	at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:45)
	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:138)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2307)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7924)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
    

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@DanielProg39
Copy link
Author

Here's a new issue. When I stop the video, turn the screen off, turn it on and turn my phone horisontally, the video doesn't expand to full screen. It does only when minimised and reopened. I tried to reproduce this behavior, you can see it below.

VID_20231030_124300_244.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant