Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when clicking next video in large playlist HTTP 429 Too many requests #5054

Closed
3 tasks done
hyperstown opened this issue Oct 29, 2023 · 0 comments · Fixed by #5058
Closed
3 tasks done

Crash when clicking next video in large playlist HTTP 429 Too many requests #5054

hyperstown opened this issue Oct 29, 2023 · 0 comments · Fixed by #5058
Labels
bug Something isn't working

Comments

@hyperstown
Copy link

hyperstown commented Oct 29, 2023

Steps to reproduce

  1. Open app
  2. Search for large playlist (over 1000 videos) (For example Touhou Archival playlist (https://www.youtube.com/playlist?list=PLRXn6V8fYj0VXqSHU_V4tDBKVEe6DmgFq)
  3. Click on playlist
  4. Click play all
  5. Switch to Audio only mode
    (App can crash at this point but not always, if it doesn't crash proceed with step 6)
  6. Play song, forward progress a little, go to next song, repeat few times.

Expected behavior

App shouldn't send so many requests that server is returning 429 error. I couldn't reproduce it with smaller playlist so maybe app is trying to get too much videos at once.
If server responds with 429 app shouldn't crash but rather prompt user it should slow down with whatever their were doing.

Actual behavior

App crashes.

Crash log
retrofit2.HttpException: HTTP 429 
 at retrofit2.KotlinExtensions$await$2$2.onResponse(SourceFile:175)
 at retrofit2.OkHttpCall$1.onResponse(SourceFile:9)
 at androidx.appcompat.app.AlertController$2.onSuccess(SourceFile:34)
 at androidx.work.Worker$2.run(SourceFile:131)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
 at java.lang.Thread.run(Thread.java:1012)
 Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@f7a38fb, Dispatchers.IO]

LibreTube version

0.19.0

Android version

Android 13

Other details

Instance: kavin.rocks

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant