Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve group buttons layout behavior #4647

Closed
3 tasks done
luckkmaxx opened this issue Aug 27, 2023 · 4 comments · Fixed by #4720
Closed
3 tasks done

Improve group buttons layout behavior #4647

luckkmaxx opened this issue Aug 27, 2023 · 4 comments · Fixed by #4720
Labels
enhancement New feature or request

Comments

@luckkmaxx
Copy link
Contributor

luckkmaxx commented Aug 27, 2023

Describe your suggested feature

  1. Instead a checkmark, show a play button to play all feed, instead long pressing. (image attached). I dont know if here is possible to add a button inside a button. Maybe the Play could be triggered when you tap once the already shown group button (wich in fact its the only that will show the ▶️ icon.
  2. Right now, the "play group" action plays the current shown group, no matter the group you touch (this would be considered a bug).
  3. What could be fine to do with a long press is to show the groups editting popup, and definitelly remove the annoying pencil.

Other details

Screenshot_20230827-125932_LibreTube Debug (1)

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@luckkmaxx luckkmaxx added the enhancement New feature or request label Aug 27, 2023
@Bnyro

This comment was marked as off-topic.

@luckkmaxx

This comment was marked as off-topic.

@Bnyro

This comment was marked as off-topic.

@Bnyro
Copy link
Member

Bnyro commented Aug 29, 2023

Getting back to the issue:

  1. I think that this would cause some UX issues, since it's very hard to tap a small button within another button and generally it's a very bad practice to put a button into an other one.
  2. I'm certain this would confuse a lot of users - we should keep everything as self-explaining as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants