Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss button not working in queue #4531

Closed
3 tasks done
luckkmaxx opened this issue Aug 17, 2023 · 11 comments · Fixed by #4532
Closed
3 tasks done

Dismiss button not working in queue #4531

luckkmaxx opened this issue Aug 17, 2023 · 11 comments · Fixed by #4532
Labels
bug Something isn't working

Comments

@luckkmaxx
Copy link
Contributor

Steps to reproduce

I think this is to hide the queue list. But it does nothing.

Expected behavior

Hide queue list?

Actual behavior

Nothing done

LibreTube version

0.17.1

Android version

13

Other details

IMG_20230817_145314

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@luckkmaxx luckkmaxx added the bug Something isn't working label Aug 17, 2023
@Bnyro
Copy link
Member

Bnyro commented Aug 17, 2023

Works fine for me, interesting. The PR should fix it anyways.

@luckkmaxx
Copy link
Contributor Author

Its tested in latest debug apk (3hrs ago)

@luckkmaxx
Copy link
Contributor Author

By long tapping it shows the "dismiss" hint, but single tap does nothing

@Bnyro
Copy link
Member

Bnyro commented Aug 17, 2023

That's why I love Android development. Every device behaves exactly the same (not)

@luckkmaxx
Copy link
Contributor Author

That's why I love Android development. Every device behaves exactly the same (not)

I will test in a less modded device. Here Im using Iconify, LSposed, and so... It shouldn interfering but maybe

@IndusAryan
Copy link
Contributor

true,one strange thing about LT i have observed that it crashes some devices and works fine on some,you guys were saying that some instances are working,none is working here

although that dismiss button was not working for me also

@luckkmaxx
Copy link
Contributor Author

Tested in a stock device. Not working

@Bnyro
Copy link
Member

Bnyro commented Aug 17, 2023

Why did I get I thumbs down when I said that all Android devices behave different @luckkmaxx ?

@luckkmaxx
Copy link
Contributor Author

Why did I get I thumbs down when I said that all Android devices behave different @luckkmaxx ?

LOL that was a thumbs down for that headaches the android development causes! Not yourself, but I hope this doesnt affect your github profile.

@luckkmaxx
Copy link
Contributor Author

Yeah now is working.

@Bnyro
Copy link
Member

Bnyro commented Aug 17, 2023

Oh haha, I thought you didn't agree with me. All fine then ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants