Remove Unique Digests #2329
Merged
Remove Unique Digests #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the unique requirements when adding a repository to the maintenance stat queue. The digests are not being reliably removed from Redis which results in a repository being locked out from getting refreshed, potentially permanently. It appears to be a known issue in the unique jobs gem: mhenrixon/sidekiq-unique-jobs#379
Keeping the repository requests unique is potentially useful, but more care needs to be taken on creating/removing the locks. Perhaps the gem will provide a fix that could be used again later?