Fix mplex notifications system #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
commented
Sep 4, 2018
| inner.to_notify.insert(TASK_ID.with(|&t| t), task::current()); | ||
| return Ok(Async::Ready(None)); | ||
| inner.notifier_read.to_notify.lock().insert(TASK_ID.with(|&t| t), task::current()); | ||
| return Ok(Async::NotReady); |
There was a problem hiding this comment.
This used to be Ready(None), which is a bug unrelated to this PR.
twittner
approved these changes
Sep 4, 2018
twittner
added a commit
to twittner/yamux
that referenced
this pull request
Sep 6, 2018
Implement a custom `Notify` implementation which in turn notifies waiting tasks. This is similar to what rust-libp2p's mplex implementation does (see libp2p/rust-libp2p#455) for details.
twittner
added a commit
to twittner/yamux
that referenced
this pull request
Sep 11, 2018
Implement a custom `Notify` implementation which in turn notifies waiting tasks. This is similar to what rust-libp2p's mplex implementation does (see libp2p/rust-libp2p#455) for details.
xmas7
pushed a commit
to RubyOnWorld/rust-yamux
that referenced
this pull request
Sep 6, 2022
Implement a custom `Notify` implementation which in turn notifies waiting tasks. This is similar to what rust-libp2p's mplex implementation does (see libp2p/rust-libp2p#455) for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #452
See the issue for a description of why this PR