Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: disable sending of Version Negotiation Packets #3396

Open
marten-seemann opened this issue Jan 27, 2023 · 0 comments
Open

quic: disable sending of Version Negotiation Packets #3396

marten-seemann opened this issue Jan 27, 2023 · 0 comments

Comments

@marten-seemann
Copy link

There's a somewhat esoteric attack, where an attacker might use QUIC Version Negotiation packets to mount a protocol confusion attack, depending on the network configuration of the server node. See libp2p/go-libp2p#1433 and https://datatracker.ietf.org/doc/html/rfc9000#name-request-forgery-attacks for details.

The good news is that we don't need QUIC's version negotiation in libp2p, as our multiaddresses (now) contain the QUIC version. We can therefore disable QUIC version negotiation. A QUIC server would then immediately drop Long Header packets with an unexpected version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant