Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm/src/behaviour: Add AndBehaviour #2719

Closed
mxinden opened this issue Jun 21, 2022 · 4 comments
Closed

swarm/src/behaviour: Add AndBehaviour #2719

mxinden opened this issue Jun 21, 2022 · 4 comments
Labels
difficulty:moderate getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted

Comments

@mxinden
Copy link
Member

mxinden commented Jun 21, 2022

Description

To combine two NetworkBehaviour implementations libp2p-swarm should provide a combinator. Contrary to NetworkBehaviour implementation of Either both NetworkBehaviour implementations would be running concurrently.

Motivation

One use-case is when wanting to either enable two NetworkBehaviours or disable both, but never enable one but disable the other.

Toggle<And<BehaviourA, BehaviourB>>

Came up here: n0-computer/iroh#126 (comment)

Requirements

Open questions

  • What is the ideal name? Off the top of my head it should be And.

Are you planning to do it yourself in a pull request?

No. Though happy to support anyone interested in contributing this.

@mxinden mxinden added difficulty:moderate help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels Jun 21, 2022
@GlenDC
Copy link

GlenDC commented Oct 7, 2022

Is it ok for me @mxinden to pick up this one, or do you have another one in mind that you want me to look at?

@mxinden
Copy link
Member Author

mxinden commented Oct 11, 2022

Please prioritize any WebRTC and Testground related work. That said, yes, help here is very much appreciated whenever you are blocked on WebRTC and Testground. Let us know in case you need any help @GlenDC.

@GlenDC
Copy link

GlenDC commented Oct 11, 2022

Understood. I am going to continue to give all my love and energy in the Protocol Labs context to Testground. Let's do it!

@jxs jxs mentioned this issue Jan 21, 2023
4 tasks
@thomaseizinger
Copy link
Contributor

I think we agreed to not do this in #3366.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:moderate getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted
Projects
None yet
Development

No branches or pull requests

3 participants