Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pubsub promisify #456

Merged
merged 2 commits into from
Sep 24, 2019
Merged

Fix pubsub promisify #456

merged 2 commits into from
Sep 24, 2019

Conversation

achingbrain
Copy link
Member

We can't use promisify to wrap the pubsub subscribe/unsubscribe functions because it thinks the handler is the callback.

Also fixes up all the linting issues flagged by the stealth upgrade of standard that went out with [email protected]

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@jacobheun jacobheun merged commit ae6af20 into master Sep 24, 2019
@jacobheun jacobheun deleted the fix-pubsub-promisify branch September 24, 2019 12:02
@jacobheun
Copy link
Contributor

Released in 0.26.2

maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
Updates stream types and abortable iterator
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants