Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix metric group timers #2789

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: fix metric group timers #2789

merged 1 commit into from
Oct 28, 2024

Conversation

achingbrain
Copy link
Member

We need to pass the metric label as the object key, otherwise trying to stop a group timer throws.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: fix metric group timers
f1811c5 
We need to pass the metric label as the object key, otherwise trying
to stop a group timer throws.
@achingbrain achingbrain requested a review from a team as a code owner October 26, 2024 07:36
@achingbrain achingbrain merged commit a4b2db1 into main Oct 28, 2024
30 checks passed
@achingbrain achingbrain deleted the fix/fix-metric-group-timers branch October 28, 2024 08:07
@achingbrain achingbrain mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @maschad