Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update customizing section to reflect service dependencies #1771

Merged
merged 9 commits into from
Jun 5, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented May 24, 2023

Closes #1763

@maschad maschad requested a review from achingbrain May 24, 2023 16:44
@vmx
Copy link
Contributor

vmx commented May 25, 2023

I was using my on configuration and was just using the pubsub service. That isn't enough, it won't find the other peers. You would also need the identify service to make it work. That should be added to the docs (thanks @achingbrain for pointing that out).

@maschad
Copy link
Member Author

maschad commented May 25, 2023

Thanks for pointing that out @vmx I've updated it.

@vmx
Copy link
Contributor

vmx commented May 25, 2023

Thanks for pointing that out @vmx I've updated it.

In the other sections the identify service is explicitly mentioned in the description and not only the code. Would it make sense to do the same for pubusb?

@maschad
Copy link
Member Author

maschad commented May 25, 2023

In the other sections the identify service is explicitly mentioned in the description and not only the code. Would it make sense to do the same for pubusb?

That's a good point. When I listed the Potential methods for discovering peers I thought that may suggest that identify protocol is implicit, but I think it would be clearer to add it explicitly.

doc/CONFIGURATION.md Outdated Show resolved Hide resolved
doc/CONFIGURATION.md Outdated Show resolved Hide resolved
maschad and others added 2 commits May 26, 2023 13:13
@maschad maschad requested a review from achingbrain May 26, 2023 18:13
doc/CONFIGURATION.md Outdated Show resolved Hide resolved
doc/CONFIGURATION.md Outdated Show resolved Hide resolved
doc/CONFIGURATION.md Outdated Show resolved Hide resolved
doc/CONFIGURATION.md Outdated Show resolved Hide resolved
doc/CONFIGURATION.md Outdated Show resolved Hide resolved
doc/CONFIGURATION.md Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit 57add26 into libp2p:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Docs: Update Customizing section of Libp2p Config to reflect Service constraints
3 participants