feat: programmatically set agentVersion in identify #1240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no agentVersion is provided to the Identity protocol, UserAgent information will be appended to the default AGENT_VERSION
Set the current libp2p version as the default AGENT_VERSION
|
@jacobheun, tagging you as the OP of the issue (: |
Provide libp2p version through a prebuild script instead of aegir define
mpetrunic
added
the
need/maintainer-input
achingbrain
changed the title
|
Thanks for submitting this, sorry it's taken me so long to get to it. It looks good but I tried to push some additional commits to this branch but it seems to be out of date so this will be continued in #1296 |
achingbrain
added a commit
that referenced
this pull request
Jul 15, 2022
If no `agentVersion` is provided for the Identify protocol, the default `AGENT_VERSION` will now be set to * `js-libp2p/<libp2p.version> UserAgent=<process.version>` when running in Node.js * `js-libp2p/<libp2p.version> UserAgent=<navigator.userAgent>` when running in the browser (also when running in a webworker) Fixes #686 Supersedes #1240 Co-authored-by: Kevin Westphal <[email protected]> Co-authored-by: Kevin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no
agentVersionis provided for the Identify protocol, the defaultAGENT_VERSIONwill now be set tojs-libp2p/<libp2p.version> UserAgent=<process.version>when running in Node.jsjs-libp2p/<libp2p.version> UserAgent=<navigator.userAgent>when running in the browser (also when running in a webworker)Fixes #686