Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink the spread of modules #509

Closed
3 of 5 tasks
daviddias opened this issue Dec 11, 2019 · 6 comments
Closed
3 of 5 tasks

Shrink the spread of modules #509

daviddias opened this issue Dec 11, 2019 · 6 comments

Comments

@daviddias
Copy link
Member

daviddias commented Dec 11, 2019

This is a continuation of the work initiated by ipfs/js-ipfs#2222

Outstanding proposals

@vasco-santos
Copy link
Member

👍

Just want to point out that libp2p/js-libp2p-utils is being used in some transports and the idea would be to continue collecting specific utils (unlikely to change) common to several repos and move them there. As a result, I think we should continue with this module

Regarding the other ones, I can take ownership of getting them done over the next weeks

@daviddias
Copy link
Member Author

Thanks for the clarification, @vasco-santos. I scratched it off the list

@daviddias
Copy link
Member Author

Hi folks! Thought of passing by and doing a check in, here are a few questions:

image

@daviddias
Copy link
Member Author

Ah, there is one more. What about https://github.com/libp2p/js-libp2p-keychain ? Will it be merged to js-libp2p as well?

@vasco-santos
Copy link
Member

libp2p-peer

We still not decided the exact way we are going to do this, but we will get rid of peer-info and keep peer-id as it is, or rename it if appropriate. If everything goes as planned, I should start working on peerstore v2 during this quarter and one of the things we intend to do during that initiative is this.

libp2p-pubsub

Currently both libp2p-floodsub and libp2p-gossipsub extend libp2p-pubsub, which contains the base building blocks for a pubsub system. We have talked before about changing this a bit though. In this case, I would say that we should create a pubsub interface instead, under the libp2p interfaces repo, which would also remove a lot of "duplicated" tests on gossipsub and floodsub. This is not a priority for now, but I think we should get to it when there is significant new work to tackle on pubsub land.

libp2p-nat-mgr

Yes. It is still not being used and as a result as not been moved there yet.

libp2p-keychain

I already created a PR to move the codebase libp2p/js-libp2p#525. However, I agree with jacob that we should change libp2p api to include it, as well as to change its usage. I also plan on taking this work during this quarter

@jacobheun
Copy link
Contributor

Released in 0.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants