We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version: latest
Subsystem: @libp2p/tcp
The hanging promise is to do with shutting down the tcp server
js-libp2p/packages/transport-tcp/src/listener.ts
Lines 364 to 372 in 1cbfd6c
For server.close to resolve all socket connections must be closed. The connections are closed inside of the close method.
server.close
Lines 306 to 308 in 1cbfd6c
The connections are tracked in the onSocket listener method with the property this.connections.
Lines 197 to 202 in 1cbfd6c
The race condition is triggered when close is called before the connection is upgraded. At that point the socket is not added to this.connections.
https://github.com/tabcat/delay5
The text was updated successfully, but these errors were encountered:
aa8de9f
Successfully merging a pull request may close this issue.
Version: latest
Subsystem: @libp2p/tcp
Severity: Low
Description
The hanging promise is to do with shutting down the tcp server
js-libp2p/packages/transport-tcp/src/listener.ts
Lines 364 to 372 in 1cbfd6c
For
server.close
to resolve all socket connections must be closed.The connections are closed inside of the close method.
js-libp2p/packages/transport-tcp/src/listener.ts
Lines 306 to 308 in 1cbfd6c
The connections are tracked in the onSocket listener method with the property this.connections.
js-libp2p/packages/transport-tcp/src/listener.ts
Lines 197 to 202 in 1cbfd6c
The race condition is triggered when close is called before the connection is upgraded. At that point the socket is not added to this.connections.
Steps to reproduce the error:
https://github.com/tabcat/delay5
The text was updated successfully, but these errors were encountered: