feat!: use single DHT only by default #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a weird dual-DHT setup whereby we have a DHT for public addresses (amino, `/ipfs/kad/1.0.0`) and a DHT for private addresess (`/ipfs/lan/kad/1.0.0`). This is an artefact of the previous libp2p setup whereby there could only be a single DHT implementation at once. Now we have services we can configure an amino DHT service and if desired an additional lan-only DHT, or the user can just use amino and not pay the overhead of running an extra DHT. Most content is resolved via the public DHT so running the lan-only DHT gives the user no benefit. BREAKING CHANGE: the `kadDHT` function returns a single DHT - see the readme for how to configure amino/lan as before
|
👍 |
wemeetagain
approved these changes
Dec 19, 2023
Merged
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a weird dual-DHT setup whereby we have a DHT for public addresses (amino,
/ipfs/kad/1.0.0) and a DHT for private addresess (/ipfs/lan/kad/1.0.0).This is an artefact of the previous libp2p setup whereby there could only be a single DHT implementation at once.
Now we have services we can configure an amino DHT service and if desired an additional lan-only DHT, or the user can just use amino and not pay the overhead of running an extra DHT.
Most content is resolved via the public DHT so running the lan-only DHT gives the user no benefit.
BREAKING CHANGE: the
kadDHTfunction returns a single DHT - see the readme for how to configure amino/lan as beforeChange checklist