Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: rename perf exports to remove Service #2227

Merged
merged 1 commit into from
Nov 10, 2023
Merged

refactor!: rename perf exports to remove Service #2227

merged 1 commit into from
Nov 10, 2023

Conversation

achingbrain
Copy link
Member

Removes the redundant Service from perf exports in line with other changes to modules in v1.

BREAKING CHANGE: the perfService export is now just perf

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
refactor!: rename perf exports to remove Service
11a9db7 
Removes the redundant `Service` from perf exports in line with other
changes to modules in v1.

BREAKING CHANGE: the `perfService` export is now just `perf`
@achingbrain achingbrain requested a review from a team as a code owner November 10, 2023 06:51
@achingbrain achingbrain merged commit d39bc23 into release-v1.0 Nov 10, 2023
21 checks passed
@achingbrain achingbrain deleted the refactor/rename-perf-exports branch November 10, 2023 07:24
achingbrain added a commit that referenced this pull request Nov 10, 2023
@achingbrain
refactor!: rename perf exports to remove Service (#2227)
d7d004e 
Removes the redundant `Service` from perf exports in line with other changes to modules in v1.

BREAKING CHANGE: the `perfService` export is now just `perf`
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Nov 10, 2023
@achingbrain @maschad
refactor!: rename perf exports to remove Service (libp2p#2227)
1ab3709 
Removes the redundant `Service` from perf exports in line with other changes to modules in v1.

BREAKING CHANGE: the `perfService` export is now just `perf`
achingbrain added a commit that referenced this pull request Nov 15, 2023
@achingbrain
refactor!: rename perf exports to remove Service (#2227)
1034416 
Removes the redundant `Service` from perf exports in line with other changes to modules in v1.

BREAKING CHANGE: the `perfService` export is now just `perf`
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain