Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash during DHT query abort when reading is slow #2225

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: crash during DHT query abort when reading is slow #2225

merged 1 commit into from
Nov 10, 2023

Conversation

achingbrain
Copy link
Member

If a DHT query is aborted during reading, the deferred promise can become rejected while nothing is awaiting it.

Switch the implementation to use a pushable queue instead.

Fixes #2216

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner November 9, 2023 18:21
@achingbrain
fix: crash during DHT query abort when reading is slow
c793838 
If a DHT query is aborted during reading, the deferred promise can
become rejected while nothing is `await`ing it.

Switch the implementation to use a `pushable` queue instead.

Fixes #2216
@achingbrain achingbrain mentioned this pull request Nov 9, 2023
Closed
@achingbrain achingbrain merged commit c960eb6 into master Nov 10, 2023
22 checks passed
@achingbrain achingbrain deleted the fix/dht-query-abort-crash branch November 10, 2023 06:15
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Nov 10, 2023
@achingbrain @maschad
fix: crash during DHT query abort when reading is slow (libp2p#2225)
eb9401e 
If a DHT query is aborted during reading, the deferred promise can become rejected while nothing is `await`ing it.

Switch the implementation to use a `pushable` queue instead.

Fixes libp2p#2216
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible unhandleable crash in kad-dht
1 participant
@achingbrain