Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only send ip/domain observed address in identify #2201

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

achingbrain
Copy link
Member

Some addresses are not naturally routable - for example incoming webrtc addresses, so do not send them as observed addresses in identify responses.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Some addresses are not naturally routable - for example incoming
webrtc addresses, so do not send them as observed addresses in
identify responses.
@achingbrain achingbrain requested a review from a team as a code owner November 6, 2023 08:08
@achingbrain achingbrain merged commit 40855f4 into master Nov 6, 2023
22 checks passed
@achingbrain achingbrain deleted the fix/only-send-routable-addresses branch November 6, 2023 08:52
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant