Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce scope of crypto module #2086

Closed
2 tasks
SgtPooki opened this issue Sep 27, 2023 · 0 comments · Fixed by #2355
Closed
2 tasks

feat: reduce scope of crypto module #2086

SgtPooki opened this issue Sep 27, 2023 · 0 comments · Fixed by #2355
Labels
need/triage Needs initial labeling and prioritization

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Sep 27, 2023

Discussed during https://pl-strflt.notion.site/js-libp2p-get-rid-of-node-forge-331d2e274b5e46e6be3f697dcf7b2c4d?pvs=4

create a new /packages/crypto folder where all the stuff that we don't use internally in libp2p

  • There are a lot of RSA keys on the network (e.g. peerId string "Qm...")
  • We can't remove import/export of the keys yet (i.e. go from pkcs1 to jwk, or pkix to jwk)
  • internal format is pwk,
  • external pkix for public keys and pkcs1 for private
  • we should move some stuff out that we can, which reduces effort later

Refs:

Tasks

@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Sep 27, 2023
@SgtPooki SgtPooki changed the title feat: pull out crypto module from libp2p package feat: reduce scope of crypto module Sep 27, 2023
@achingbrain achingbrain moved this to 🤨Needs Investigation in js-libp2p Dec 12, 2023
@github-project-automation github-project-automation bot moved this from 🤨Needs Investigation to 🎉Done in js-libp2p Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant