Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@libp2p/protocol-perf): use noise for encryption #1992

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented Aug 25, 2023

Closes #1991

@maschad maschad requested a review from a team as a code owner August 25, 2023 14:31
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxinden's comment in #1991 was:

For a better comparison, consider using TLS or Noise in the js-libp2p perf implementation as well.

This is "instead of" rather than "as well", is that correct?

There doesn't seem to be an option to select the encryption method so this is probably what was intended?

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Noise instead of plaintext. Opposite to the interop tests, the perf benchmarks can not (yet) select a security protocol.

@achingbrain achingbrain changed the title feat(@libp2p/protocol-perf): use noise for encryption fix(@libp2p/protocol-perf): use noise for encryption Aug 25, 2023
@achingbrain achingbrain merged commit 24c1c24 into libp2p:master Aug 25, 2023
17 checks passed
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(protocol/perf): consider using tls or noise instead of plaintext
3 participants