Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update Customizing section of Libp2p Config to reflect Service constraints #1763

Closed
maschad opened this issue May 18, 2023 · 0 comments · Fixed by #1771
Closed

Docs: Update Customizing section of Libp2p Config to reflect Service constraints #1763

maschad opened this issue May 18, 2023 · 0 comments · Fixed by #1771
Assignees
@maschad
Labels
P1 High: Likely tackled by core team if no one steps up topic/docs Documentation

Comments

@maschad
Copy link
Member

maschad commented May 18, 2023

Description:

The customization section of the docs should reflect that we do facilitate the custom modules being passed in as services in the Libp2p config but also ensure that consumers understand that some services depend on others e.g. such as circuit relay v2 and kad-dht don't really work without identify
@maschad maschad added the need/triage Needs initial labeling and prioritization label May 18, 2023
@maschad maschad mentioned this issue May 18, 2023
Closed
@maschad maschad moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p May 22, 2023
@maschad maschad added topic/docs Documentation P1 High: Likely tackled by core team if no one steps up and removed need/triage Needs initial labeling and prioritization labels May 23, 2023
@maschad maschad self-assigned this May 23, 2023
@maschad maschad moved this from 🥞Weekly Candidates/Discuss🎙 to 🏃‍♀️In Progress in js-libp2p May 23, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue May 24, 2023
@maschad
docs: update customizing section to reflect service dependencies (lib…
a8ad048 
…p2p#1763)
@maschad maschad mentioned this issue May 24, 2023
Merged
maschad added a commit to maschad/js-libp2p that referenced this issue May 25, 2023
@maschad
docs: added identify service to pubsub example (libp2p#1763)
d794df5
maschad added a commit to maschad/js-libp2p that referenced this issue May 25, 2023
@maschad
docs: added identify service info to pubsub docs (libp2p#1763)
07b6d01
@maschad maschad moved this from 🏃‍♀️In Progress to 🥸In Review in js-libp2p May 25, 2023
achingbrain added a commit that referenced this issue Jun 5, 2023
@maschad @achingbrain
docs: update customizing section to reflect service dependencies (#1771)
57add26 
Closes #1763

Co-authored-by: Alex Potsides <[email protected]>

---------

Co-authored-by: Alex Potsides <[email protected]>
@github-project-automation github-project-automation bot moved this from 🥸In Review to 🎉Done in js-libp2p Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maschad maschad

Labels
P1 High: Likely tackled by core team if no one steps up topic/docs Documentation
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update customizing section to reflect service dependencies maschad/js-libp2p
1 participant
@maschad