Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connections to Allow list peers should not be pruned #1515

Closed
achingbrain opened this issue Dec 6, 2022 · 0 comments · Fixed by #1564
Closed

Connections to Allow list peers should not be pruned #1515

achingbrain opened this issue Dec 6, 2022 · 0 comments · Fixed by #1564
Assignees
@maschad
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue

Comments

@achingbrain
Copy link
Member

When connection limits are breached, connections can be pruned to bring the node back under it's limits.

Allow lists are supported to allow certain peers to always open connections, connections from these peers should be excluded from connection pruning.
@achingbrain achingbrain added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors labels Dec 6, 2022
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 8, 2022
@maschad
fix: should not prune a peer that is in the allow list once the conne…
7d17a3b 
…ction limit is reached (libp2p#1515)
@maschad maschad mentioned this issue Dec 8, 2022
Closed
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 13, 2022
@maschad
fix: should not prune a peer that is in the allow list once the conne…
2ec8606 
…ction limit is reached (libp2p#1515)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 15, 2022
@maschad
fix: should not prune a peer that is in the allow list once the conne…
6812ac1 
…ction limit is reached (libp2p#1515)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 16, 2022
@maschad
fix: should not prune a peer that is in the allow list once the conne…
24f7709 
…ction limit is reached (libp2p#1515)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 3, 2023
@maschad
fix: should not prune a peer that is in the allow list once the conne…
1c3484b 
…ction limit is reached (libp2p#1515)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 4, 2023
@maschad
fix: should not prune a peer that is in the allow list once the conne…
72abe72 
…ction limit is reached (libp2p#1515)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 7, 2023
@maschad
fix: should not prune a peer that is in the allow list once the conne…
80dc00d 
…ction limit is reached (libp2p#1515)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 16, 2023
@maschad
fix: should not prune a peer that is in the allow list once the conne…
9344798 
…ction limit is reached (libp2p#1515)
maschad added a commit to maschad/js-libp2p that referenced this issue Jan 18, 2023
@maschad
fix: should not prune a peer that is in the allow list once the conne…
deea23b 
…ction limit is reached (libp2p#1515)
@maschad maschad mentioned this issue Jan 18, 2023
Merged
maschad added a commit to maschad/js-libp2p that referenced this issue Feb 1, 2023
@maschad
fix: do not prune a peer that is in the allowlist + fix tests (libp2p…
1c04b61 
…#1515)
@maschad maschad self-assigned this Feb 6, 2023
achingbrain pushed a commit that referenced this issue Mar 21, 2023
@maschad
fix: Connections to Allow list peers will not be pruned (#1564)
f9e5450 
If the connection manager needs to reduce the number of active connections, do not close connections to peers that are in the allow list.

Closes #1515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maschad maschad

Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Connections to Allow list peers will not be pruned maschad/js-libp2p
2 participants
@achingbrain @maschad