Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

fix: listener get addrs with wss #130

Merged
merged 1 commit into from
Jun 8, 2021
Merged

fix: listener get addrs with wss #130

merged 1 commit into from
Jun 8, 2021

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented May 28, 2021 •
edited
Loading

Related to the flagged issue in libp2p/js-libp2p#930

Shortly, when libp2p calls libp2p.transportManager.getAddrs(), the underlying websockets transport would return a ws multiaddr when listening on a wss multiaddr and this address was being incorrectly advertised

@lidel lidel mentioned this pull request May 31, 2021
Merged
@lidel lidel added the P1 High: Likely tackled by core team if no one steps up label Jun 7, 2021
@lidel lidel requested a review from yusefnapora June 7, 2021 14:32
yusefnapora
yusefnapora approved these changes Jun 7, 2021
View reviewed changes
Copy link

@yusefnapora yusefnapora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I like iterating over the protos instead of searching the stringified address for ip4 - that's a nice touch.

@vasco-santos vasco-santos merged commit ee47570 into master Jun 8, 2021
@vasco-santos vasco-santos deleted the fix/listener-get-addrs-with-wss branch June 8, 2021 07:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yusefnapora yusefnapora yusefnapora approved these changes

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
P1 High: Likely tackled by core team if no one steps up
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasco-santos @yusefnapora @lidel