Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Commit

Permalink
fix: onConnect does not follow callback pattern (#36)
Browse files Browse the repository at this point in the history
  • Loading branch information
daviddias authored Nov 8, 2016
1 parent ebce595 commit a821c33
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"pull-ws": "^3.2.8"
},
"devDependencies": {
"aegir": "^9.0.1",
"aegir": "^9.1.1",
"chai": "^3.5.0",
"gulp": "^3.9.1",
"interface-transport": "^0.3.3",
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ module.exports = class WebSockets {
log('dialing %s', url)
const socket = connect(url, {
binary: true,
onConnect: callback
onConnect: () => callback

This comment has been minimized.

Copy link
@dignifiedquire

dignifiedquire Nov 8, 2016

Member

@diasdavid this is wrong, this means callback will be never called

This comment has been minimized.

Copy link
@daviddias

daviddias Nov 8, 2016

Author Member

True, was fooled by a local running version

Fixed in the next following commit 0429beb

"CR'ing 5 chars might get someone annoyed, he thought"

})

const conn = new Connection(socket)
Expand Down

0 comments on commit a821c33

Please sign in to comment.