feat: retrieve peers on connect #64
Conversation
test/discovery.spec.js
Outdated
| cb() | ||
| }) | ||
| }), done) | ||
| }) |
There was a problem hiding this comment.
Browser tests are failing because it's trying to spin up a rendezvous server. Aegir spins up a few servers in .aegir.js, https://github.com/libp2p/js-libp2p-websocket-star/blob/v0.9.1/.aegir.js#L9. Using those servers should resolve the failing browser tests.
There was a problem hiding this comment.
The reason I was spinning up new rendezvous servers was that the existing servers still had some state from previous tests. So now instead of spinning up new servers I made some changes to the previous tests to clean up old connections
dirkmc
force-pushed
the
feat/get-peers-on-connect
branch
from
590c65a
to
6e3bc1b
Compare
There was a problem hiding this comment.
The issue with the lingering connections is that .close is not actually closing the sockets. Per the interface-transport, https://github.com/libp2p/interface-transport#stop-a-listener, .close should have a timeout to forcefully close connections. Right now it just waits for them to close themselves which is why the other tests needed to have their pull streams ended.
This needs to get fixed, but shouldn't block this PR. This effort would be good to lump in with the accept/reject updates https://github.com/libp2p/interface-transport/issues/39.
Get peers from rendezvous server on connect, and emit a
peerevent for each oneDepends on libp2p/js-libp2p-websocket-star-rendezvous#27
See peer-base/peer-base#75 (comment) for details