This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
fix!: remove @libp2p/components #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…depends on every interface, meaning when one interface revs a major `@libp2p/components` major has to change too which means every module depending on it also needs a major. Switch instead to constructor injection of simple objects that let modules declare their dependencies on interfaces directly instead of indirectly via `@libp2p/components` Refs libp2p/js-libp2p-components#6 BREAKING CHANGE: modules no longer implement `Initializable` instead switching to constructor injection
achingbrain
changed the title
@libp2p/components is a choke-point for our dependency graph as it …
github-actions bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
## [@libp2p/webrtc-star-v5.0.0](https://github.com/libp2p/js-libp2p-webrtc-star/compare/@libp2p/webrtc-star-v4.0.1...@libp2p/webrtc-star-v5.0.0) (2022-10-12) ### ⚠ BREAKING CHANGES * modules no longer implement `Initializable` instead switching to constructor injection ### Bug Fixes * remove @libp2p/components ([#477](#477)) ([efbcd99](efbcd99))
|
🎉 This PR is included in version @libp2p/webrtc-star-v5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@libp2p/componentsis a choke-point for our dependency graph as it depends on every interface, meaning when one interface revs a major@libp2p/componentsmajor has to change too which means every module depending on it also needs a major.Switch instead to constructor injection of simple objects that let modules declare their dependencies on interfaces directly instead of indirectly via
@libp2p/componentsRefs libp2p/js-libp2p-components#6
BREAKING CHANGE: modules no longer implement
Initializableinstead switching to constructor injection