Skip to content
This repository has been archived by the owner on Aug 23, 2019. It is now read-only.

fix: improve stopping logic #324

Merged
merged 5 commits into from
Apr 4, 2019
Merged

fix: improve stopping logic #324

merged 5 commits into from
Apr 4, 2019

Conversation

jacobheun
Copy link
Contributor

This includes code from #322 and builds off of it to fix some other stopping issues.

  1. Connections weren't allowing disconnect when upgrading. So if a close was attempted while muxing was being negotiated the connection wouldn't close. I updated an existing test to better catch this.
  2. When stopping, if a listener errors during close it would cause stopping to fail. This change logs the error out and continues on with stopping the switch to ensure all connections are terminated.

Also, if starting errored it would only log the error out and not stop the switch, this corrects that.

@ghost ghost assigned jacobheun Apr 4, 2019
@ghost ghost added the in progress label Apr 4, 2019
@jacobheun jacobheun marked this pull request as ready for review April 4, 2019 11:10
@jacobheun jacobheun merged commit 5f9a4f6 into master Apr 4, 2019
@jacobheun jacobheun deleted the fix/stopping branch April 4, 2019 11:42
@ghost ghost removed the in progress label Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants