Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[switch] start and stop accepting connections #440

Closed
pgte opened this issue Apr 23, 2018 · 4 comments · Fixed by #2058
Closed

[switch] start and stop accepting connections #440

pgte opened this issue Apr 23, 2018 · 4 comments · Fixed by #2058

Comments

@pgte
Copy link
Contributor

pgte commented Apr 23, 2018

For each different transport individually, in order to do connection throttling, it's important to be able to start and stop the listener by command of the user.

@pgte
Copy link
Contributor Author

pgte commented Apr 23, 2018

@pgte
Copy link
Contributor Author

pgte commented Apr 23, 2018

Also the UTP transport has the same issue:

@pgte pgte self-assigned this Apr 23, 2018
@pgte
Copy link
Contributor Author

pgte commented Apr 23, 2018

@diasdavid there's an incongruence in the interface-transport docs:

options is an optional object that might contain the following properties:

  • timeout - A timeout value (in ms) that fires and destroys all the connections on this transport if the transport is not able to close graciously. (e.g { timeout: 1000 })

@jacobheun
Copy link
Contributor

We will also need to remove/change the interface-stream-muxer test at https://github.com/libp2p/interface-stream-muxer/blob/v0.5.9/src/close-test.js#L37, as it expects the muxer connections to close when the listener is closed. Instead it should validate the connection is still usable.

@pgte pgte removed their assignment Nov 21, 2018
@daviddias daviddias changed the title start and stop accepting connections [switch] start and stop accepting connections Aug 22, 2019
@daviddias daviddias transferred this issue from libp2p/js-libp2p-switch Aug 22, 2019
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants