Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

feat: add exportToJSON #9

Closed
wants to merge 1 commit into from

Conversation

wemeetagain
Copy link
Member

Matches exportToProtobuf

@wemeetagain wemeetagain force-pushed the feat/add-factory-export-to-json branch from 22f7281 to c2255a0 Compare June 28, 2022 02:47
@achingbrain
Copy link
Member

I think we should really remove these createFromX and exportToX methods as from what I can see they don't get used anywhere outside of tests - it's pretty cheap to create Ed25519 keys as they are just 32 random bytes and we'll then be able to drop the protobuf deps from the peer-id-factory module.

Where are you using these methods?

@wemeetagain
Copy link
Member Author

I was using to/from JSON to persist our network identity in lodestar. Not a huge thing if we decide to remove that here.

@BigLep
Copy link

BigLep commented Sep 6, 2022

Closing because of consensus that this functionality shouldn't be part of the library.

@BigLep BigLep closed this Sep 6, 2022
@sneaker1 sneaker1 mentioned this pull request Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants