This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: select first record when no selector function #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
added
the
status/blocked
ghost
assigned 
vasco-santos
force-pushed
the
feat/select-first-record-when-no-selector-function
branch
from
8e28554
to
29bbf7e
Compare
vasco-santos
removed
the
status/blocked
jacobheun
suggested changes
Nov 8, 2018
src/private.js
Outdated
| } catch (err) { | ||
| // Assume the first record if no selector available | ||
| if (err.code !== 'ERR_NO_SELECTOR_FUNCTION_FOR_RECORD_KEY') { | ||
| return callback(err) |
There was a problem hiding this comment.
@vasco-santos maybe we should add another error test to check this callback behavior. It won't matter now, but if we start doing any checking in the waterfall callback this might fail. callback should be cb so the rest of waterfall executes.
There was a problem hiding this comment.
right, it is better to have that test now than have tests failing later. Will add it now.
jacobheun
reviewed
Nov 8, 2018
Co-Authored-By: vasco-santos <[email protected]>
jacobheun
approved these changes
Nov 8, 2018
vasco-santos
deleted the
feat/select-first-record-when-no-selector-function
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select first record when no selector function exists for it. Currently, it throws an handled exception and
go-ipfsallows other types of keys.