Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

fix: find peer and providers options #45

Merged
merged 2 commits into from
Sep 27, 2018
Merged

fix: find peer and providers options #45

merged 2 commits into from
Sep 27, 2018

Conversation

vasco-santos
Copy link
Member

Aiming to allow other future options to findPeer and findProviders, I changed themaxTimeout param to an object options.

In the context of

@ghost ghost assigned vasco-santos Sep 26, 2018
@ghost ghost added the status/in-progress In progress label Sep 26, 2018
This was referenced Sep 26, 2018
Merged
Merged
@jacobheun
Copy link
Contributor

Changes look good, not sure why CI is not registering tests.

@jacobheun
Copy link
Contributor

jacobheun commented Sep 26, 2018 •
edited
Loading

@vasco-santos it looks like the recent jenkins updates look for test:node test:browser and test:webworker. If all those are empty it can't find tests. We'll need to add at least "test:node": "aegir test -t node", to package.json.

@vasco-santos
Copy link
Member Author

Oh thanks! I will add it now

@vasco-santos
Copy link
Member Author

@jacobheun CI is green now. Once you approve this, I can release a new version of the package for you to use on:

jacobheun
jacobheun approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just need to include the release in the libp2p updates. The delegated routing modules are good to merge once you approve them.

@vasco-santos vasco-santos merged commit bba7500 into master Sep 27, 2018
@ghost ghost removed the status/in-progress In progress label Sep 27, 2018
@vasco-santos vasco-santos deleted the fix/dht-find-peer-and-providers-options branch September 27, 2018 10:07
@vasco-santos
Copy link
Member Author

done! 🚀

@vasco-santos vasco-santos mentioned this pull request Oct 29, 2018
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees

@vasco-santos vasco-santos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @jacobheun