Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

randomWalk start/stop does not take callbacks #111

Closed
kumavis opened this issue May 8, 2019 · 2 comments
Closed

randomWalk start/stop does not take callbacks #111

kumavis opened this issue May 8, 2019 · 2 comments

Comments

@kumavis
Copy link
Contributor

kumavis commented May 8, 2019 •
edited
Loading

randomWalk.start() and randomWalk.stop() should take callbacks
https://github.com/libp2p/js-libp2p-kad-dht/blob/master/src/random-walk.js#L41

https://github.com/libp2p/interface-peer-discovery#api

Edit: interface has been updated to use promises instead of callbacks
@kumavis kumavis mentioned this issue May 8, 2019
Closed
@kumavis
Copy link
Contributor Author

kumavis commented May 8, 2019

libp2p-webrtc-star does implement this correctly
https://github.com/libp2p/js-libp2p-webrtc-star/blob/master/src/index.js#L46-L47

@andycodesstuff andycodesstuff mentioned this issue Aug 24, 2019
Closed
@vasco-santos
Copy link
Member

Closing this in favour of #44 that should be addressed once we refactor the DHT with the new spec.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kumavis @vasco-santos