Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Stop ongoing random-walk query if stopped #102

Open
vasco-santos opened this issue Apr 17, 2019 · 1 comment
Open

Stop ongoing random-walk query if stopped #102

vasco-santos opened this issue Apr 17, 2019 · 1 comment
Assignees
@jacobheun
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP status/ready Ready to be worked

Comments

@vasco-santos
Copy link
Member

As discussed on libp2p/js-libp2p-kad-dht#101, we should stop ab ongoing random-walk query if the random-walk is stopped, as we will not get anything from the queries results
@vasco-santos vasco-santos added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue P0 Critical: Tackled by core team ASAP status/ready Ready to be worked labels Apr 17, 2019
@vasco-santos vasco-santos mentioned this issue Apr 17, 2019
Merged
@jacobheun jacobheun self-assigned this Apr 17, 2019
@jacobheun
Copy link
Contributor

With #104, once findPeer has support for AbortController, aborting an active random walk query will happen automatically provided findPeer is given the AbortController signal via options.signal

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jacobheun jacobheun

Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobheun @vasco-santos