Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

[transport] listener.close() *should* close existing connections and there should be .accept()/.reject() functions instead #30

Closed
mkg20001 opened this issue Aug 16, 2018 · 1 comment

Comments

@mkg20001
Copy link
Member

With the new proposal in place that transports don't close existing connections when stop is called and only stop to accept any new there arises a new bug: Connections will be left unclosed once the libp2p instance shuts down and will keep the process from exiting properly.

Instead there should be two new functions, .accept() and .reject(), that control whether or not a transport should accept new connections and .stop() should close all connections as usual.

@jacobheun jacobheun changed the title .stop() *should* close existing connections and there should be .accept()/.reject() functions instead listener.close() *should* close existing connections and there should be .accept()/.reject() functions instead Nov 9, 2018
@daviddias daviddias changed the title listener.close() *should* close existing connections and there should be .accept()/.reject() functions instead [transport] listener.close() *should* close existing connections and there should be .accept()/.reject() functions instead Feb 5, 2020
@daviddias daviddias transferred this issue from libp2p/interface-transport Feb 5, 2020
@achingbrain
Copy link
Member

Closing as this is very stale

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants