You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
With the new proposal in place that transports don't close existing connections when stop is called and only stop to accept any new there arises a new bug: Connections will be left unclosed once the libp2p instance shuts down and will keep the process from exiting properly.
Instead there should be two new functions, .accept() and .reject(), that control whether or not a transport should accept new connections and .stop() should close all connections as usual.
The text was updated successfully, but these errors were encountered:
jacobheun
changed the title
.stop() *should* close existing connections and there should be .accept()/.reject() functions instead
listener.close() *should* close existing connections and there should be .accept()/.reject() functions instead
Nov 9, 2018
daviddias
changed the title
listener.close() *should* close existing connections and there should be .accept()/.reject() functions instead
[transport] listener.close() *should* close existing connections and there should be .accept()/.reject() functions instead
Feb 5, 2020
With the new proposal in place that transports don't close existing connections when stop is called and only stop to accept any new there arises a new bug: Connections will be left unclosed once the libp2p instance shuts down and will keep the process from exiting properly.
Instead there should be two new functions, .accept() and .reject(), that control whether or not a transport should accept new connections and .stop() should close all connections as usual.
The text was updated successfully, but these errors were encountered: