This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
perf: remove asn1.js and use node-forge #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be failing on chrome 😢 I re-run both chrome jobs, but no luck! We need to investigate, because this would be a nice gain |
|
@vasco-santos aye, is still WIP, I’ve not even removed everything I need to in order to remove asn1.js yet! I just submitted the PR for visibility and intent. |
🎉 |
alanshaw
commented
Feb 17, 2020
|
Should be ready for review now |
|
Looks like this is also working upstream at ipfs/js-ipfs#2785 |
vasco-santos
approved these changes
Feb 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are already using
asn1fromnode-forgein the code base. This PR removes theasn1.jsdependency and uses the code we already imported fromnode-forgeinstead.It should remove ~20 KB (gzipped) from the bundle.
https://tools.ietf.org/html/rfc7518