This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
perf: remove jwk2privPem and jwk2pubPem #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These 2 unused functions required us to import the whole of the node-forge PKI implementation when we only use some RSA stuffs.
jacobheun
approved these changes
Feb 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two unused functions required us to import the whole of the node-forge PKI implementation when we only use some RSA stuffs.
I thought this was going to lead to a big saving but then I realised that
libp2p-keychainrequirespkcs7fromnode-forgewhich brings in a bunch of other modules...It saves 34KB, but that only translates to 2KB when minified and gzipped. Still it's something, and I've done the research work now so might as well submit it 🤷♂️
Before:
After: