Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Connection Gater from transport constructors that take an Upgrader #951

Closed
aarshkshah1992 opened this issue May 21, 2020 · 1 comment
Closed

Remove Connection Gater from transport constructors that take an Upgrader #951

aarshkshah1992 opened this issue May 21, 2020 · 1 comment
Assignees
@aarshkshah1992
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@aarshkshah1992
Copy link
Contributor

We don't need it because the Upgrader already has it. See:

#881 (comment).
@aarshkshah1992 aarshkshah1992 added the kind/enhancement A net-new feature or improvement to an existing feature label May 21, 2020
@aarshkshah1992 aarshkshah1992 self-assigned this May 21, 2020
@aarshkshah1992 aarshkshah1992 mentioned this issue May 21, 2020
Merged
@marten-seemann
Copy link
Contributor

This is needed because the QUIC constructor takes a ConnectionGater (but no Upgrader): https://github.com/libp2p/go-libp2p-quic-transport/blob/47b90e048cfc99b7cf9e7c377d6af9525483ef9f/transport.go#L129-L130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarshkshah1992 aarshkshah1992

Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marten-seemann @aarshkshah1992