Upgrading only patch version breaks build

[fxfactorial]

the diff

-       github.com/libp2p/go-libp2p-core v0.5.3
+       github.com/libp2p/go-libp2p-core v0.5.5

the crash:

building cmd/bootnode/main.go
# github.com/libp2p/go-libp2p-peerstore/pstoremem
../../../../pkg/mod/github.com/libp2p/[email protected]/pstoremem/protobook.go:29:5: cannot use (*memoryProtoBook)(nil) (type *memoryProtoBook) as type "github.com/libp2p/go-libp2p-core/peerstore".ProtoBook in assignment:
	*memoryProtoBook does not implement "github.com/libp2p/go-libp2p-core/peerstore".ProtoBook (missing FirstSupportedProtocol method)

the go.mod

require (
	github.com/Workiva/go-datastructures v1.0.50
	github.com/allegro/bigcache v1.2.1 // indirect
	github.com/aristanetworks/goarista v0.0.0-20190607111240-52c2a7864a08 // indirect
	github.com/aws/aws-sdk-go v1.30.1
	github.com/beorn7/perks v1.0.1 // indirect
	github.com/btcsuite/btcutil v0.0.0-20190425235716-9e5f4b9a998d
	github.com/cespare/cp v1.1.1
	github.com/davecgh/go-spew v1.1.1
	github.com/davidlazar/go-crypto v0.0.0-20190912175916-7055855a373f // indirect
	github.com/deckarep/golang-set v1.7.1
	github.com/edsrzf/mmap-go v1.0.0 // indirect
	github.com/ethereum/go-ethereum v1.8.27
	github.com/fjl/memsize v0.0.0-20180929194037-2a09253e352a // indirect
	github.com/garslo/gogen v0.0.0-20170307003452-d6ebae628c7c // indirect
	github.com/golang/mock v1.3.1
	github.com/golang/protobuf v1.3.5
	github.com/golangci/golangci-lint v1.22.2
	github.com/gorilla/handlers v1.4.0 // indirect
	github.com/gorilla/mux v1.7.4
	github.com/harmony-ek/gencodec v0.0.0-20190215044613-e6740dbdd846
	github.com/harmony-one/bls v0.0.6
	github.com/harmony-one/taggedrlp v0.1.4
	github.com/harmony-one/vdf v0.0.0-20190924175951-620379da8849
	github.com/hashicorp/golang-lru v0.5.4
	github.com/iancoleman/strcase v0.0.0-20190422225806-e506e3ef7365
	github.com/ipfs/go-ds-badger v0.2.4
	github.com/jackpal/gateway v1.0.6 // indirect
	github.com/jbenet/go-temp-err-catcher v0.1.0 // indirect
	github.com/karalabe/hid v1.0.0 // indirect
	github.com/kylelemons/godebug v1.1.0 // indirect
	github.com/libp2p/go-addr-util v0.0.2 // indirect
	github.com/libp2p/go-libp2p v0.8.3
	github.com/libp2p/go-libp2p-core v0.5.5
	github.com/libp2p/go-libp2p-crypto v0.1.0
	github.com/libp2p/go-libp2p-discovery v0.4.0
	github.com/libp2p/go-libp2p-host v0.1.0
	github.com/libp2p/go-libp2p-kad-dht v0.5.0
	github.com/libp2p/go-libp2p-net v0.1.0
	github.com/libp2p/go-libp2p-peer v0.2.0
	github.com/libp2p/go-libp2p-peerstore v0.2.3
	github.com/libp2p/go-libp2p-pubsub v0.2.7
	github.com/multiformats/go-multiaddr v0.2.2
	github.com/multiformats/go-multiaddr-net v0.1.5
	github.com/natefinch/lumberjack v2.0.0+incompatible
	github.com/pborman/uuid v1.2.0
	github.com/pkg/errors v0.9.1
	github.com/prometheus/common v0.4.1 // indirect
	github.com/prometheus/procfs v0.0.3 // indirect
	github.com/rjeczalik/notify v0.9.2
	github.com/rs/cors v1.7.0 // indirect
	github.com/rs/zerolog v1.18.0
	github.com/shirou/gopsutil v2.18.12+incompatible // indirect
	github.com/spf13/viper v1.6.1
	github.com/stretchr/testify v1.5.1
	github.com/syndtr/goleveldb v1.0.1-0.20190923125748-758128399b1d
	github.com/uber/jaeger-client-go v2.20.1+incompatible // indirect
	github.com/uber/jaeger-lib v2.2.0+incompatible // indirect
	go.uber.org/zap v1.14.1 // indirect
	golang.org/x/crypto v0.0.0-20200406173513-056763e48d71
	golang.org/x/lint v0.0.0-20200302205851-738671d3881b
	golang.org/x/net v0.0.0-20200324143707-d3edc9973b7e // indirect
	golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
	golang.org/x/sys v0.0.0-20200413165638-669c56c373c4 // indirect
	golang.org/x/tools v0.0.0-20200408032209-46bd65c8538f
	google.golang.org/grpc v1.28.1
	gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15
	gopkg.in/natefinch/lumberjack.v2 v2.0.0 // indirect
	gopkg.in/natefinch/npipe.v2 v2.0.0-20160621034901-c1b8fa8bdcce // indirect
	gopkg.in/urfave/cli.v1 v1.20.0 // indirect
	gopkg.in/yaml.v2 v2.2.7
)

[aarshkshah1992]

@fxfactorial Please can you upgrade go-libp2p-peerstoreto the latest released version i.e. v0.2.4 ?

@raulk Should we do a release of go-libp2p with the updated core and peerstore changes ?

[Stebalien]

👍

(we should also try to cut minor releases for changes like this)

[raulk]

👎 We can’t. We need to solve this follow-up before we make a release to avoid causing a regression with QUIC: #931

[aarshkshah1992]

@fxfactorial Please use go-libp2p version v0.9.0 and this should be fixed.