Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go get -u fails with go 1.12.5, win64 #647

Closed
dowlandaiello opened this issue May 24, 2019 · 5 comments
Closed

go get -u fails with go 1.12.5, win64 #647

dowlandaiello opened this issue May 24, 2019 · 5 comments

Comments

@dowlandaiello
Copy link

Pretty straightforward, was just updating my modules as per usual (no code changed, just a routine module update). go get -u (with GO111MODULES=on in the GOPATH) seemed to be bugging out at transport-upgrader and basic host. Logs:

go: finding github.com/whyrusleeping/mdns latest
# github.com/libp2p/go-libp2p-transport-upgrader
R:\Go\pkg\mod\github.com\libp2p\g[email protected]\upgrader.go:80:12: undefined: ipnet.ForcePrivateNetwork
# github.com/libp2p/go-libp2p/p2p/host/basic
R:\Go\pkg\mod\github.com\libp2p\g[email protected]\p2p\host\basic\basic_host.go:145:32: cannot use h (type *BasicHost) as type host.Host in argument to identify.NewIDService:
        *BasicHost does not implement host.Host (wrong type for Mux method)
                have Mux() *multistream.MultistreamMuxer
                want Mux() "github.com/libp2p/go-libp2p-core/protocol".Switch
R:\Go\pkg\mod\github.com\libp2p\g[email protected]\p2p\host\basic\basic_host.go:172:32: cannot use h (type *BasicHost) as type host.Host in argument to ping.NewPingService:
        *BasicHost does not implement host.Host (wrong type for Mux method)
                have Mux() *multistream.MultistreamMuxer
                want Mux() "github.com/libp2p/go-libp2p-core/protocol".Switch
@dowlandaiello
Copy link
Author

dowlandaiello commented May 24, 2019

Quick note: This seems like an upstream issue. Just tried go get -u on a super simple libp2p hello world project, same error.

EDIT: Tried go getting with GO111MODULE off. Still the same issue. :(

@Stebalien
Copy link
Member

Yes, this is an issue as we've made some changes to our dependencies but haven't finished bubbling them up. Please use go get -u=patch for now.

@hsanjuan
Copy link
Contributor

hello, you can do go get github.com/libp2p/[email protected] and go get github.com/libp2p/[email protected]. That should fix those problems (they may come up when running with -u=patch too depending on your project).

@raulk
Copy link
Member

raulk commented May 24, 2019

Posted a NOTICE under #649. Thanks for the patience, it’ll be worth it. For now, please follow @hsanjuan’s instructions.

@Stebalien
Copy link
Member

Closing in favor of #649.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants