-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rcmgr: warn if limits conflict with connmgr #1707
Comments
Hi @MarcoPolo, id be interested in picking this up, but I would need a bit of clarification from you about how you think this should work. It looks to me like a good place to insert the check would be just after this block, since everything should have been configured by that point: Lines 297 to 302 in 4caa4e5
However the resource manager in Thanks! |
Thanks @piersy! Here's what I'm thinking:
Conn manager defines a new interface for the thing it checks its limits against. And the resourceManager implements this interface. The glue code in NewNode checks to see if the configured resource manager implements the interface and calls the There's probably some subtleties here, but hopefully this is enough to get you started :) |
Thanks @MarcoPolo, that sounds good to me! |
We should emit some warning if the current limits conflict with the current settings for the connection manager.
Roughly:
I think this makes sense to put in the connmgr code.
The text was updated successfully, but these errors were encountered: