You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is confusing to users of the library, we shouldn't define states that we're not actually using.
Furthermore, we should introduce a ConnectedViaTransientConnection state, and emit that instead of Connected when we establish a transient (i.e. a connection via a relay), and emit another Connected event once we transition from a transient to a direct connection.
We're currently defining 4 different states for the
Connectedness
: https://pkg.go.dev/github.com/libp2p/[email protected]/network#Connectedness, of which we're only usingNotConnected
andConnected
.This is confusing to users of the library, we shouldn't define states that we're not actually using.
Furthermore, we should introduce a
ConnectedViaTransientConnection
state, and emit that instead ofConnected
when we establish a transient (i.e. a connection via a relay), and emit anotherConnected
event once we transition from a transient to a direct connection.This came up in #1562.
cc @MarcoPolo @Stebalien
The text was updated successfully, but these errors were encountered: