Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pstoremanager: flaky TestClose #1589

Closed
marten-seemann opened this issue Jun 2, 2022 · 1 comment · Fixed by #1649
Closed

pstoremanager: flaky TestClose #1589

marten-seemann opened this issue Jun 2, 2022 · 1 comment · Fixed by #1649
Assignees
@marten-seemann
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor 

  === CONT  TestClose
      pstoremanager_test.go:111: Hit timeout
      controller.go:269: missing call(s) to *pstoremanager_test.MockPeerstore.RemovePeer(is equal to t1Zv2yaZ (peer.ID)) /Users/runner/work/go-libp2p/go-libp2p/p2p/host/pstoremanager/pstoremanager_test.go:106
      controller.go:269: aborting test due to missing call(s)
  --- FAIL: TestClose (5.14s)
@marten-seemann marten-seemann added the kind/bug A bug in existing code (including security flaws) label Jun 2, 2022
@marten-seemann
Copy link
Contributor Author

The problem here is that the event bus might take some time to process the event. Even though we send the event before we close, this doesn't mean that the pstoremanager received the event.

@marten-seemann marten-seemann mentioned this issue Jul 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marten-seemann marten-seemann

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pstoremanager: fix flaky TestClose libp2p/go-libp2p
2 participants
@MarcoPolo @marten-seemann